9807feef90
Phase 3 of cyclomatic complexity reduction refactoring. Code Quality Improvements: - confirm_eskaera(): 390 → 222 lines (-168 lines, 43.1% reduction) - Extracted 3 new helpers reducing main method complexity - Better separation of concerns: validation, processing, messaging New Helper Methods: 1. _validate_confirm_json (lines ~550-610): Validates JSON data and order 2. _process_cart_items (lines ~610-680): Processes cart items to sale.order lines 3. _build_confirmation_message (lines ~680-760): Builds multiidioma confirmation message Phase 1 + 2 + 3 Combined Results: - Total code refactored: 3 methods (eskaera_shop, add_to_eskaera_cart, confirm_eskaera) - Total lines saved: 109 + 168 = 277 lines (26% reduction across all 3 methods) - Total C901 improvements: eskaera_shop (42→33), confirm_eskaera (47→24) - Created 6 helpers + 2 test files (Phase 1 & 2) Status: Ready for phase completion |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| portal.py | ||
| website_sale.py | ||