Commit graph

8 commits

Author SHA1 Message Date
GitHub Copilot
fbd43bb459
[REF] all: pass pre-commit on the whole repo
Some checks failed
CI / lint (pull_request) Successful in 33s
CI / test (pull_request) Failing after 9m29s
CI / review (pull_request) Has been skipped
Needed for the lint job of the CI to go green. Mostly automatic hook
fixes (black, isort, prettier, pyupgrade, autoflake, whitespace). By hand:

- flake8: two unused imports, an ambiguous variable name `l`.
- pylint-odoo mandatory: manifest keys equal to their default value
  (installable, application, data, external_dependencies).
- end-of-file-fixer skips *.patch too, like trailing-whitespace: the
  upstream patches stay as git format-patch wrote them.

No behaviour change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-04 14:34:58 +02:00
GitHub Copilot
fad510f69e
[FIX] pre-commit: do not strip trailing whitespace from patches
The blank context lines of a diff are a single space: stripping it breaks
pos_payment_method_cashdro_fix/upstream/*.patch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-04 14:34:58 +02:00
GitHub Copilot
87dcb4e350 cron better exception management. show supplier commercial name in product card template. linters config 2026-06-02 10:43:54 +02:00
snt
9937e987f4 [I18N] website_sale_aplicoop: Limpieza de traducciones y etiquetas UI en inglés por defecto 2026-02-26 14:33:44 +01:00
snt
0a2cc4c8c4 [FIX] Code quality refactoring: remove F401, fix translations, improve test coverage
- Remove unused imports (F401) across multiple addons (__init__.py files)
- Fix W8161 (prefer-env-translation): replace global _() with self.env._() and request.env._()
- Fix W8301 (translation-not-lazy): use named placeholders instead of % formatting
  - group_order.py: Fix 2 constraint messages
  - wizard_update_product_category.py: Fix notification message
- Fix E722 (bare except): add proper Exception handling with logging in website_sale.py
- Fix W8116/E8102 (post-migrate.py): remove cr.commit() and print(), add logging
- Fix W8150 (relative imports): update test_templates_rendering.py imports
- Fix F841 (assigned but unused): Remove unused variable assignments in tests
- Add mypy.ini with exclude pattern for migrations to avoid duplicate module errors
- Add __init__.py files in migration directories for proper Python package structure
- Restore migration scripts (post-migration.py) that were deleted
- Update pyproject.toml with mypy configuration
- Replace print() with logging in test_prices.py
- Fix CSS indentation in header.css
- Add portal access tests to improve test coverage

This refactoring improves:
- Code quality: All F401, E722, W8161, W8301, W8150, E8102/W8116 violations resolved
- Internationalization: Proper use of env._() with lazy formatting
- Testing: Reduced unused variable assignments and improved portal user testing
- Linting: All pre-commit hooks passing (except non-critical B018, C8116, W8113)
2026-02-21 02:13:40 +01:00
snt
6fbc7b9456 [FIX] website_sale_aplicoop: Remove redundant string= attributes and fix OCA linting warnings
- Remove redundant string= from 17 field definitions where name matches string value (W8113)
- Convert @staticmethod to instance methods in selection methods for proper self.env._() access
- Fix W8161 (prefer-env-translation) by using self.env._() instead of standalone _()
- Fix W8301/W8115 (translation-not-lazy) by proper placement of % interpolation outside self.env._()
- Remove unused imports of odoo._ from group_order.py and sale_order_extension.py
- All OCA linting warnings in website_sale_aplicoop main models are now resolved

Changes:
- website_sale_aplicoop/models/group_order.py: 21 field definitions cleaned
- website_sale_aplicoop/models/sale_order_extension.py: 5 field definitions cleaned + @staticmethod conversion
- Consistent with OCA standards for addon submission
2026-02-18 17:54:43 +01:00
snt
4207afbc3f update pylint10, corrije authors manifest 2026-02-12 17:15:33 +01:00
snt
fe137dc265 build: configurar herramientas de verificación OCA
- Instalar pre-commit con 25 hooks configurados
- Configurar black 26.1.0 para formateo de código Python
- Configurar isort 7.0.0 para ordenación de imports
- Configurar flake8 7.3.0 con flake8-bugbear
- Configurar pylint 3.1.1 con pylint-odoo 9.1.2
- Añadir autoflake y pyupgrade para mejoras automáticas
- Configurar prettier para formateo de XML/JSON/YAML
- Crear .editorconfig para consistencia de editor
- Crear Makefile con comandos útiles
- Crear check_addon.sh para verificación rápida de addons
- Actualizar configuración de VS Code con extensiones recomendadas
- Añadir documentación completa de uso
- Aplicar formateo automático a archivos existentes
- Deshabilitar setuptools-odoo (no soporta Odoo 18.0 aún)
- Deshabilitar fix-encoding-pragma (obsoleto, usar pyupgrade)
2026-02-11 16:09:41 +01:00