CriptoMart/addons-cm
2
0
Fork 0
Code Issues 2 Pull requests Releases Wiki Activity

[FIX] website_sale_aplicoop: Remove redundant string= attributes and fix OCA linting warnings

Browse source 
- Remove redundant string= from 17 field definitions where name matches string value (W8113)
- Convert @staticmethod to instance methods in selection methods for proper self.env._() access
- Fix W8161 (prefer-env-translation) by using self.env._() instead of standalone _()
- Fix W8301/W8115 (translation-not-lazy) by proper placement of % interpolation outside self.env._()
- Remove unused imports of odoo._ from group_order.py and sale_order_extension.py
- All OCA linting warnings in website_sale_aplicoop main models are now resolved

Changes:
- website_sale_aplicoop/models/group_order.py: 21 field definitions cleaned
- website_sale_aplicoop/models/sale_order_extension.py: 5 field definitions cleaned + @staticmethod conversion
- Consistent with OCA standards for addon submission
This commit is contained in:
snt 2026-02-18 17:54:43 +01:00
parent 5c89795e30
commit 6fbc7b9456
73 changed files with 5386 additions and 4354 deletions
Download patch file Download diff file Expand all files Collapse all files

10
website_sale_aplicoop/views/portal_templates.xml
View file

@ -9,7 +9,7 @@
<th>Pickup Day</th>
<th class="text-center">Actions</th>
</xpath>
<!-- Add data cells for each order row -->
<xpath expr="//t[@t-foreach='orders']//tr//td[last()]" position="after">
<td>
@ -35,15 +35,15 @@
<td class="text-center">
<t t-if="order.group_order_id">
<!-- Load in Cart button: available for all states -->
<a t-attf-href="/eskaera/#{order.group_order_id.id}/load-from-history/#{order.id}"
class="btn btn-sm btn-primary me-1"
<a t-attf-href="/eskaera/#{order.group_order_id.id}/load-from-history/#{order.id}"
class="btn btn-sm btn-primary me-1"
t-att-title="'Load order items into cart' if order.state == 'draft' else 'Create new order from this one'">
<i class="fa fa-cart-arrow-down"></i>
</a>
<!-- Confirm button: only for draft orders -->
<t t-if="order.state == 'draft'">
<a t-attf-href="/eskaera/#{order.group_order_id.id}/checkout"
class="btn btn-sm btn-success"
class="btn btn-sm btn-success"
title="Go to checkout to review and confirm order">
<i class="fa fa-check"></i>
</a>
@ -57,7 +57,7 @@
<template id="portal_order_page_sidebar_button" inherit_id="sale.sale_order_portal_template" name="Order Page - Add Load in Cart Button">
<xpath expr="//div[@id='sale_order_sidebar_button']" position="inside">
<t t-if="sale_order.group_order_id">
<a t-attf-href="/eskaera/#{sale_order.group_order_id.id}/load-from-history/#{sale_order.id}"
<a t-attf-href="/eskaera/#{sale_order.group_order_id.id}/load-from-history/#{sale_order.id}"
class="btn btn-primary" role="button">
<i class="fa fa-cart-arrow-down me-1" aria-hidden="true"></i>
<span>Load in Cart</span>