CriptoMart/addons-cm
2
0
Fork 0
Code Issues 2 Pull requests Releases Wiki Activity

[FIX] website_sale_aplicoop: Remove redundant string= attributes and fix OCA linting warnings

Browse source 
- Remove redundant string= from 17 field definitions where name matches string value (W8113)
- Convert @staticmethod to instance methods in selection methods for proper self.env._() access
- Fix W8161 (prefer-env-translation) by using self.env._() instead of standalone _()
- Fix W8301/W8115 (translation-not-lazy) by proper placement of % interpolation outside self.env._()
- Remove unused imports of odoo._ from group_order.py and sale_order_extension.py
- All OCA linting warnings in website_sale_aplicoop main models are now resolved

Changes:
- website_sale_aplicoop/models/group_order.py: 21 field definitions cleaned
- website_sale_aplicoop/models/sale_order_extension.py: 5 field definitions cleaned + @staticmethod conversion
- Consistent with OCA standards for addon submission
This commit is contained in:
snt 2026-02-18 17:54:43 +01:00
parent 5c89795e30
commit 6fbc7b9456
73 changed files with 5386 additions and 4354 deletions
Download patch file Download diff file Expand all files Collapse all files

11
website_sale_aplicoop/controllers/website_sale.py
View file

@ -1809,10 +1809,8 @@ class AplicoopWebsiteSale(WebsiteSale):
)
_logger.warning("========================================")
# Get delivery product ID and name (translated to user's language)
delivery_product = request.env.ref(
"website_sale_aplicoop.product_home_delivery", raise_if_not_found=False
)
# Get delivery product from group_order (configured per group order)
delivery_product = group_order.delivery_product_id
delivery_product_id = delivery_product.id if delivery_product else None
# Get translated product name based on current language
if delivery_product:
@ -2804,9 +2802,8 @@ class AplicoopWebsiteSale(WebsiteSale):
return request.redirect("/eskaera/%d" % sale_order.group_order_id.id)
# Extract items from the order (skip delivery product)
delivery_product = request.env.ref(
"website_sale_aplicoop.product_home_delivery", raise_if_not_found=False
)
# Use the delivery_product_id from the group_order
delivery_product = sale_order.group_order_id.delivery_product_id
delivery_product_id = delivery_product.id if delivery_product else None
items = []