[FIX] stock_picking_batch_custom: validar collected solo en operaciones detalladas

stock_picking_batch_custom/tests/test_batch_summary.py

@@ -344,19 +344,38 @@ class TestBatchSummary(TransactionCase):
         )
         self.assertAlmostEqual(line_product2.qty_demanded, 10.0)
 
-    def test_done_requires_all_summary_lines_collected_without_backorder(self):
-        """Full validation still blocks if processed products are unchecked."""
+    def test_done_requires_detailed_lines_collected_without_backorder(self):
+        """Full validation blocks when detailed operation lines are unchecked."""
 
         batch = self._create_batch_with_pickings()
         batch.action_confirm()
         batch._compute_summary_line_ids()
 
-        self.assertTrue(batch.summary_line_ids)
-        self.assertFalse(batch.summary_line_ids.mapped("is_collected")[0])
+        detail_lines = batch.move_line_ids.filtered(lambda line: line.quantity > 0)
+        self.assertTrue(detail_lines)
+        self.assertFalse(any(detail_lines.mapped("is_collected")))
 
         with self.assertRaises(UserError):
             batch.action_done()
 
+    def test_done_ignores_product_summary_checkbox(self):
+        """Product Summary checkbox is informative and must not block validation."""
+
+        batch = self._create_batch_with_pickings()
+        batch.action_confirm()
+        batch._compute_summary_line_ids()
+
+        # Keep Product Summary unchecked on purpose
+        self.assertFalse(any(batch.summary_line_ids.mapped("is_collected")))
+
+        # Detailed lines drive validation
+        batch.move_line_ids.filtered(lambda line: line.quantity > 0).write(
+            {"is_collected": True}
+        )
+
+        # Should not raise
+        batch.action_done()
+
     def test_partial_validation_waits_for_backorder_wizard_before_blocking(self):
         """Partial batch validation must open the backorder wizard first."""
 
@@ -373,13 +392,20 @@ class TestBatchSummary(TransactionCase):
         self.assertIsInstance(action, dict)
         self.assertEqual(action.get("res_model"), "stock.backorder.confirmation")
 
-    def test_partial_validation_checks_only_processed_products(self):
-        """Unchecked lines with no processed quantity must remain informative."""
+    def test_partial_validation_checks_only_processed_detailed_lines(self):
+        """Only processed detailed lines must be required for collected."""
 
         batch = self._create_partial_batch(extra_move=True)
 
+        # Ensure product_2 remains non-processed in this scenario
+        move_product_2 = batch.move_ids.filtered(
+            lambda move: move.product_id == self.product_2
+        )
+        move_product_2.write({"quantity": 0.0})
+        move_product_2.move_line_ids.write({"quantity": 0.0})
+
         with self.assertRaisesRegex(UserError, self.product.display_name) as err:
-            batch._check_all_products_collected([self.product.id])
+            batch._check_all_products_collected(batch.picking_ids)
 
         self.assertNotIn(self.product_2.display_name, str(err.exception))
 
@@ -389,7 +415,9 @@ class TestBatchSummary(TransactionCase):
         batch = self._create_batch_with_pickings()
         batch.action_confirm()
         batch._compute_summary_line_ids()
-        batch.summary_line_ids.write({"is_collected": True})
+        batch.move_line_ids.filtered(lambda line: line.quantity > 0).write(
+            {"is_collected": True}
+        )
 
         # Should not raise
         batch._check_all_products_collected()